Repository navigation
deps: update old and remove unused dependencies - #49
Conversation
|
GitHub seems to have caught up with itself. |
|
@fabiojose just checking in - any thoughts on this? |
|
@lance take a look at my reviews. We are dropping the support for 6, 7 and 8, right? |
|
@fabiojose yes - this commit bumps the tested Node.js versions to 10 and 12. All other versions of Node.js are currently EOL (Node.js 8 may still be in maintenance mode, but it will EOL at the end of April). I don't see any reviews from you on this. 🤷 |
201fc8b to
7c1a627
Compare
fabiojose
left a comment
fabiojose
left a comment
There was a problem hiding this comment.
Sorry, my bad! Did not save them. Now they are here.
| @@ -1,13 +1,12 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 8 | |||
There was a problem hiding this comment.
People with node 8, 7 and 6 will be able to use cloudevent released with version 12?
There was a problem hiding this comment.
It's possible, but not guaranteed. I don't think the SDK uses language features that are not available in 6, 7 and 8. But I question the wisdom of even attempting to support a Node.js version that is end of life. Both 6 and 8 are EOL, and 7 was never an LTS version (no odd numbered versions of Node.js should be considered LTS ever).
|
@lance Can you add the entry in the CHANGELOG.md and fix that conflicting files? |
This commit updates all of the dependencies in package.json to their most recent versions. It also removes dependencies that were specified in package.json but not used - or only used in a `require()` statement. These changes have some ripple effects. Istanbul has not been supported for some time, so it has been replaced with nyc. The code coverage reporting tool from codacy has been updated as well. This could not be tested without having the API token. Finally, the CI job has been modified to run tests on Node.js versions 10x and 12x. All older versions of Node.js are no longer maintained. Signed-off-by: Lance Ball <lball@redhat.com>
7c1a627 to
aa2cef6
Compare
|
@fabiojose requested changes have been made. |
|
@fabiojose did you see my comment here? The problem occurs during CI and seems to be an issue with the codacy script possibly not handling things well. I don't have credentials to publish codacy results or configure travis, so it's impossible for me to test this. When I run locally I get this: **######################################################################## 100.0%
######################################################################## 100.0%
2020-04-29 12:27:25,617 ERROR com.codacy Invalid configuration: Either a project token or an api token must be provided or available in an environment variable
**Note, that in this commit, the code coverage reporting changed here. I noted this in the original PR text:
I'll keep poking but I suspect I'll either need credentials for Travis and Codacy or someone who has those credentials will need to fix it. The failure began with the Merge commit based on this PR. But as you can see, the PR itself passed the Travis build with no problems. https://travis-ci.org/github/cloudevents/sdk-javascript/builds/677389800 So I'm happy to continue trying to figure out what went wrong, but not sure I can be successful without proper credentials. |
|
Seems all is ok. |
This commit updates all of the dependencies in package.json to
their most recent versions. It also removes dependencies that were
specified in package.json but not used - or only used in a
require()statement.These changes have some ripple effects. Istanbul has not been
supported for some time, so it has been replaced with nyc.
The code coverage reporting tool from codacy has been updated
as well. This could not be tested without having the API token.
Finally, the CI job has been modified to run tests on Node.js
versions 10x and 12x. All older versions of Node.js are no longer
maintained.
Fixes: #50